Cyanide wrote:
def choices():
- choice = []
- for i in range(3):
-- choice.append(vocab[random.randint(0,5)][1])
- return choice
I'm not quite sure what you're trying to do here. The function choices() as written here looks like it will return a list of 3 randomly chosen second parts of the elements in vocab.
If you're trying to get a list of 3 items without repeats, you need some way to prevent it from returning a duplicate. Keeping a list of already used elements and using some code to reselect if you picked something that was previously used would work. Probably a better way would be to have a list of possible choices and delete previously used choices. If you want to try deleting elements from a list, you probably will want to make a temporary list to hold your options, since you probably don't want to change your global vocab list.
Your variable naming could be improved here. It doesn't matter to the computer what you name your variables, it would be perfectly happy with xyz12354 for a variable name, but it does matter to people, and bad variable names can be very confusing.
The function choices() and the list choice[] have names that are too similar. It's too easy to confuse them. I'd probably name the list choices[], since it contains several choices, and rename the function. Maybe to choose(), since verbs make good function names (in general), but that's still pretty similar. You understand what you're trying to do better than I do, so you can probably come up with a better name than I did.
Quote:
def quiz():
- points = 0
- for (chunk) in vocab:
-- random.shuffle(chunk[0])
-- print(chunk[0])
Again with the variable names: chunk refers to a single element in vocab. When I think of a vocabulary and imagine selecting a particular vocabulary element, I think of the word 'word', so I'd suggest renaming chunk to word.
What your call to random.shuffle() is trying to shuffle is a single element of your vocabulary, so it's probably not actually doing anything. How many different ways can you arrange a single element in order? Only one, because you can't rearrange the order of one object. This shows how powerful good naming can be in programming; since if you had named chunk word (or vocab_element or something), then you probably would have caught that yourself.
Lastly, if I understand what you're trying to do here, you probably want to do the random.shuffle() call outside of the loop, since if you changed it from how it is now to reshuffling the entire vocab list, it would end up getting reshuffled every time you went through the loop.
_________________
"A dead thing can go with the stream, but only a living thing can go against it." --G. K. Chesterton
12 Nov 2011, 7:12 pm
