There is a tendency of those of us on the spectrum to take constructive critisicm too personally. You need to chat with your coworkers and find out if it is constructive or if the guy is just a Dickhead.
If the guy is NOT a Dickhead I would advice that you construct the code his way since he is the lead and you can learn style from him.
If the guy IS a Dickhead I would advice that you construct the code his way since he is a Dickhead and can make life miserable for you because he is a Dickhead with power over you. (but you have no need to take it personal since he is only a Dickhead)
I've been doing coding for 40+ years and each person and each lead has their own style and way they like things done. I keep improving my style by working with and adapting to the style of others. There is always something useful and new in other peoples style.
PS: Man up and strap on a pair. If the lead continues to spend time with you and your code it means that he believes you and your work product is worth spending his time on. You need to start worrying if he stops spending the time.
hmk66 wrote:
Maybe there are coding guidelines which you have to follow.
A long while ago, I was a programmer. (I was not fired because of programming skills that would lack, but because of staying too separate from the team and lacking social skills).
There were written coding guidelines and there were courses or meetings from time to time in which that was explained. Secondly the editor that we use (before we feed the code to the compiler) was programmed in a way that made it easy to follow the guidelines.
Still you have to discuss why your code was wrongly written and why your boss's code wasn't. Or you could ask for guidelines for coding as I wrote above. I don't know your company's rules.
If a boss gives too little criticism (or no criticism at all) to an employee, it seems to be nice, but it finally will "bite" him in the back, like I experienced. I was overprotected, didn't learn much and finally the supervisor think that I have no organizational skills, not an ability to learn anything, have a intellectual retardation, etc. And I didn't see that opinion coming.
You will be overprotected and you won't learn a thing. Therefore I agree with Btbnnyr and Adamantium. I just learned a new saying in English: Sparing the rod and spoiling the child.
We do all off that. 99% of my code is either enforced by Visual Studio or PEP8 ( Python guidelines ) I will agree I had some misspellings, but a new plugin I just installed will take care of those. When it comes to other guidelines there are none. And I started working here before him. I was the one who started working on the test project.
The point I'm making isn't that he should always be nice and treat us like kindergarten students. I know that is destructive. And he should tell us when we do something sub-optimal. The point I'm making is that to always deal harsh critisicm is not a good thing. It's nice knowing when I do something right too. And I think that goes for just about everyone.
And, I might be a bit over-sensitive on this. But to me there is a difference between taking my code and returning the same code, just refactored. Or the tonality of the critisicm. If someone tells me "This is wrong, do this" It makes me frustrated and feel quite worthless. It would be better if he joined med at my desk and had a look through my code, telling me what he though and what he thinks needed to be changed. It would also be more interactive than just comments on a code review.
hmk66 wrote:
morslilleole wrote:
Instead of saying saying "this is wrong, THIS is how it should be."
Then you could compare the code as it should be, with your could and try to see the differences. If you once find out, you will also know how to code from now on. Sometimes you have to find out things for yourself.
That makes it sound like it's a lesson. Isn't there a saying that goes. "You're not gonna learn anything if I do it for you" But yes, I do try to gain experience from it. Though sometimes it's more "oh, he wants it this way. I guess I'll write it like that then"
19 Nov 2015, 2:13 pm
