Others have said it, but the key is practice. Lots and lots of practice. I love photography, but just reading about it or looking at other people's photos (important as both are), won't translate into better photographs. I love learning about and memorizing all kinds of arcane information about vintage and new cameras, but that just makes me a walking encyclopedia on the subject.
When I first got into photography at 16 or 17, I was passionate about taking pictures. There was no digital photography back then, so after my one photography class in high school (where I had the luxury of using the school darkroom for free), I had to pay to get each roll developed. A lot of my PT job income went to pay for film processing and prints, and there was an agonizing wait to see what I'd shot! With digital, I might have learned faster, but I was persistent. Aside from the occasional lucky, shot, though, my photos weren't that great. A lot of my peers, who didn't share my obsession, seemed to take consistently better images than I did with little effort.
Over the years I dabbled, and never really saw big improvements in my work. Most of my photos - film or digital - were technically adequate, but boring. I got really serious again about photography starting back around 2007 and haven't put it down since. I still wasn't that great (I'd be embarrassed to show you some of my early attempts at shooting amateur models), but I kept at it diligently. I began noticing improvements as experience taught me to recognize whether I'd be happy with the shot later. I learned how to change my framing, my angle, my compositions, deal with challenging lighting, etc. I experimented with different lighting techniques - setting up test shots of things I knew I'd never do anything with.
And I got better. Slower than most to really master the craft (and I wouldn't even claim I've mastered it), but years of persistence have paid off. So just because you don't see progress in a year or two (or 10 years, for that matter), doesn't mean that you won't get there. But you have GOT to stick with the thing that you're pursuing, even when you're thinking "I should be better by now!"
If you give up and decide to move to something else instead, you'll likely have to begin the process all over again. Just make sure that whatever it is you're trying to improve at is worth that level of commitment.
_________________
Formally diagnosed with ASD at the age of 43 (2014), I am the author of "Never One of Them: Growing Up With Autism," available through Amazon and most popular ebook sites.
My Official Facebook Page